vcc_gnd
/
esp-who
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix UB by avoiding duplicate httpd_resp_send_x

pull/139/head
7FM 2020-04-01 16:22:08 +02:00 committed by 7FM
parent 86623ba27f
commit 3a404d6f63
1 changed files with 16 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
examples/single_chip/camera_web_server/main/app_httpd.c
View File

@ -692,8 +692,10 @@ static esp_err_t cmd_handler(httpd_req_t *req)
char variable[32]; char variable[32];
char value[32]; char value[32];
if (parse_get(req, &buf) != ESP_OK || if (parse_get(req, &buf) != ESP_OK) {
httpd_query_key_value(buf, "var", variable, sizeof(variable)) != ESP_OK || return ESP_FAIL;
}
if (httpd_query_key_value(buf, "var", variable, sizeof(variable)) != ESP_OK ||
httpd_query_key_value(buf, "val", value, sizeof(value)) != ESP_OK) { httpd_query_key_value(buf, "val", value, sizeof(value)) != ESP_OK) {
free(buf); free(buf);
httpd_resp_send_404(req); httpd_resp_send_404(req);
@ -901,8 +903,10 @@ static esp_err_t xclk_handler(httpd_req_t *req)
char *buf = NULL; char *buf = NULL;
char _xclk[32]; char _xclk[32];
if (parse_get(req, &buf) != ESP_OK || if (parse_get(req, &buf) != ESP_OK) {
httpd_query_key_value(buf, "xclk", _xclk, sizeof(_xclk)) != ESP_OK) { return ESP_FAIL;
}
if (httpd_query_key_value(buf, "xclk", _xclk, sizeof(_xclk)) != ESP_OK) {
free(buf); free(buf);
httpd_resp_send_404(req); httpd_resp_send_404(req);
return ESP_FAIL; return ESP_FAIL;
@ -929,8 +933,10 @@ static esp_err_t reg_handler(httpd_req_t *req)
char _mask[32]; char _mask[32];
char _val[32]; char _val[32];
if (parse_get(req, &buf) != ESP_OK || if (parse_get(req, &buf) != ESP_OK) {
httpd_query_key_value(buf, "reg", _reg, sizeof(_reg)) != ESP_OK || return ESP_FAIL;
}
if (httpd_query_key_value(buf, "reg", _reg, sizeof(_reg)) != ESP_OK ||
httpd_query_key_value(buf, "mask", _mask, sizeof(_mask)) != ESP_OK || httpd_query_key_value(buf, "mask", _mask, sizeof(_mask)) != ESP_OK ||
httpd_query_key_value(buf, "val", _val, sizeof(_val)) != ESP_OK) { httpd_query_key_value(buf, "val", _val, sizeof(_val)) != ESP_OK) {
free(buf); free(buf);
@ -960,8 +966,10 @@ static esp_err_t greg_handler(httpd_req_t *req)
char _reg[32]; char _reg[32];
char _mask[32]; char _mask[32];
if (parse_get(req, &buf) != ESP_OK || if (parse_get(req, &buf) != ESP_OK) {
httpd_query_key_value(buf, "reg", _reg, sizeof(_reg)) != ESP_OK || return ESP_FAIL;
}
if (httpd_query_key_value(buf, "reg", _reg, sizeof(_reg)) != ESP_OK ||
httpd_query_key_value(buf, "mask", _mask, sizeof(_mask)) != ESP_OK) { httpd_query_key_value(buf, "mask", _mask, sizeof(_mask)) != ESP_OK) {
free(buf); free(buf);
httpd_resp_send_404(req); httpd_resp_send_404(req);
@ -998,8 +1006,6 @@ static esp_err_t pll_handler(httpd_req_t *req)
char *buf = NULL; char *buf = NULL;
if (parse_get(req, &buf) != ESP_OK) { if (parse_get(req, &buf) != ESP_OK) {
free(buf);
httpd_resp_send_404(req);
return ESP_FAIL; return ESP_FAIL;
} }
@ -1029,8 +1035,6 @@ static esp_err_t win_handler(httpd_req_t *req)
char *buf = NULL; char *buf = NULL;
if (parse_get(req, &buf) != ESP_OK) { if (parse_get(req, &buf) != ESP_OK) {
free(buf);
httpd_resp_send_404(req);
return ESP_FAIL; return ESP_FAIL;
} }